Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the BuilderAttribs struct public #516

Closed
tomaka opened this issue Jul 5, 2015 · 1 comment
Closed

Make the BuilderAttribs struct public #516

tomaka opened this issue Jul 5, 2015 · 1 comment

Comments

@tomaka
Copy link
Contributor

tomaka commented Jul 5, 2015

The with_blabla API seems a bit too magical to me.
I think it would be beneficial to show the user that it simply modifies some fields in the attributes, and that the user can manually modify them as well. It would also make it possible to expose the default values in a clean fashion.

However the struct would need some cleanup before being made public (it's not just adding pub in front of it). For example the headless member should disappear. I also don't want it to be possible to have an invalid state.
This was referenced Sep 20, 2015
Merged
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Nov 3, 2016

Done.

@tomaka tomaka closed this as completed Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaka