Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to close window #13

Closed
humb1t opened this issue Jul 5, 2016 · 4 comments
Closed

Add method to close window #13

humb1t opened this issue Jul 5, 2016 · 4 comments
Labels
C - needs discussion Direction must be ironed out D - easy Likely easier than most tasks here P - low Nice to have S - api Design and usability S - enhancement Wouldn't this be the coolest?

Comments

@humb1t
Copy link

humb1t commented Jul 5, 2016

You provided a possibility to create/show/hide/resize window:
pub fn hide(&self) { self.window.hide() }
But I sure that 'pub fn close' method is also can be provided.
@LFalch
Copy link

LFalch commented Jul 5, 2016

Can't you just drop the object?

@humb1t
Copy link
Author

humb1t commented Jul 6, 2016

Yes, I can. But this is not the same.

@tomaka tomaka added S - api Design and usability and removed S - api Design and usability labels Nov 3, 2016
@francesca64 francesca64 mentioned this issue Mar 5, 2018
Merged
@francesca64 francesca64 mentioned this issue Mar 23, 2018
Closed
@francesca64
Copy link
Member

@humb1t in what way should it be different?

@francesca64 francesca64 added S - enhancement Wouldn't this be the coolest? C - needs discussion Direction must be ironed out D - easy Likely easier than most tasks here P - low Nice to have labels May 6, 2018
@Osspial
Copy link
Contributor

Osspial commented Dec 22, 2018

It looks like the consensus as per #434 is that we aren't going to add a close method, so I'm going to close this issue.

@Osspial Osspial closed this as completed Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C - needs discussion Direction must be ironed out D - easy Likely easier than most tasks here P - low Nice to have S - api Design and usability S - enhancement Wouldn't this be the coolest?
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tomaka @LFalch @francesca64 @humb1t @Osspial