From b182bc68e5d23b5f17ddc4972c53a2942e93fd9b Mon Sep 17 00:00:00 2001 From: Mads Marquart Date: Thu, 11 Aug 2022 11:24:26 +0200 Subject: [PATCH 1/4] Add CODEOWNERS file This makes it very clear when you're stepping down from the post as a maintainer, and makes it clear for users who is expected to review their PR --- .github/CODEOWNERS | 33 +++++++++++++++++++++++++++++++++ CONTRIBUTING.md | 5 ++--- HALL_OF_CHAMPIONS.md | 3 +++ 3 files changed, 38 insertions(+), 3 deletions(-) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000000..b65a027f2a --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,33 @@ +# Core maintainers: +# - @msiglreith +# - @kchibisov +# - @madsmtm +# - @maroider + +# Android +/src/platform/android.rs @msiglreith +/src/platform_impl/android @msiglreith + +# iOS +/src/platform/ios.rs @francesca64 +/src/platform_impl/ios @francesca64 + +# Wayland +/src/platform/unix.rs @kchibisov +/src/platform_impl/linux/wayland @kchibisov +/src/platform_impl/linux/mod.rs @kchibisov + +# X11 (no maintainer) +/src/platform_impl/linux/x11 + +# macOS +/src/platform/macos.rs @madsmtm +/src/platform_impl/macos @madsmtm + +# Web (no maintainer) +/src/platform/web.rs +/src/platform_impl/web + +# Windows +/src/platform/windows.rs @msiglreith +/src/platform_impl/windows @msiglreith diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 021d8a043e..a484bc0f93 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -44,10 +44,9 @@ Once your PR is deemed ready, the merging maintainer will take care of resolving ## Maintainers & Testers -The current [list of testers and contributors](https://github.com/rust-windowing/winit/wiki/Testers-and-Contributors) -can be found on the Wiki. +The current maintainers is listed in the [CODEOWNERS](.github/CODEOWNERS) file. -If you are interested in contributing or testing on a platform, please add yourself to that table! +If you are interested in being pinged when testing is needed for a certain platform, please add yourself to the [Testers and Contributors](https://github.com/rust-windowing/winit/wiki/Testers-and-Contributors) table! ## Making a new release diff --git a/HALL_OF_CHAMPIONS.md b/HALL_OF_CHAMPIONS.md index 111f368289..29aaada0bb 100644 --- a/HALL_OF_CHAMPIONS.md +++ b/HALL_OF_CHAMPIONS.md @@ -15,9 +15,12 @@ future endeavors: vastly more sustainable era of winit. * [@goddessfreya]: For selflessly taking over maintainership of glutin, and her stellar dedication to improving both winit and glutin. +* [@ArturKovacs]: For constently maintaining the macOS backend, and his + immense involvement in designing and implementing the new keyboard API. [@tomaka]: https://github.com/tomaka [@vberger]: https://github.com/vberger [@francesca64]: https://github.com/francesca64 [@Osspial]: https://github.com/Osspial [@goddessfreya]: https://github.com/goddessfreya +[@ArturKovacs]: https://github.com/ArturKovacs From 5d7c07ae61391b44ddd1a3b4846f8696b81b4416 Mon Sep 17 00:00:00 2001 From: Mads Marquart Date: Thu, 11 Aug 2022 13:37:45 +0200 Subject: [PATCH 2/4] Fix grammar Co-authored-by: Kirill Chibisov --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a484bc0f93..5c287f14de 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -44,7 +44,7 @@ Once your PR is deemed ready, the merging maintainer will take care of resolving ## Maintainers & Testers -The current maintainers is listed in the [CODEOWNERS](.github/CODEOWNERS) file. +The current maintainers are listed in the [CODEOWNERS](.github/CODEOWNERS) file. If you are interested in being pinged when testing is needed for a certain platform, please add yourself to the [Testers and Contributors](https://github.com/rust-windowing/winit/wiki/Testers-and-Contributors) table! From 10fd8fe17d116edb3068554e5ffb352d77c4410e Mon Sep 17 00:00:00 2001 From: Mads Marquart Date: Thu, 11 Aug 2022 13:39:45 +0200 Subject: [PATCH 3/4] Make @kchibisov receive pings for the X11 platform --- .github/CODEOWNERS | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index b65a027f2a..9de26e778e 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -12,13 +12,15 @@ /src/platform/ios.rs @francesca64 /src/platform_impl/ios @francesca64 -# Wayland +# Unix in general /src/platform/unix.rs @kchibisov -/src/platform_impl/linux/wayland @kchibisov /src/platform_impl/linux/mod.rs @kchibisov -# X11 (no maintainer) -/src/platform_impl/linux/x11 +# Wayland +/src/platform_impl/linux/wayland @kchibisov + +# X11 +/src/platform_impl/linux/x11 @kchibisov # macOS /src/platform/macos.rs @madsmtm From 1c0b9ace5ee314a1adf09c12aa31d8932c5c3c63 Mon Sep 17 00:00:00 2001 From: Mads Marquart Date: Thu, 11 Aug 2022 14:47:33 +0200 Subject: [PATCH 4/4] Fix typo --- HALL_OF_CHAMPIONS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/HALL_OF_CHAMPIONS.md b/HALL_OF_CHAMPIONS.md index 29aaada0bb..eab9433be4 100644 --- a/HALL_OF_CHAMPIONS.md +++ b/HALL_OF_CHAMPIONS.md @@ -15,7 +15,7 @@ future endeavors: vastly more sustainable era of winit. * [@goddessfreya]: For selflessly taking over maintainership of glutin, and her stellar dedication to improving both winit and glutin. -* [@ArturKovacs]: For constently maintaining the macOS backend, and his +* [@ArturKovacs]: For consistently maintaining the macOS backend, and his immense involvement in designing and implementing the new keyboard API. [@tomaka]: https://github.com/tomaka