Append mode isn't supported

[rustprooflabs]

Details

This issue was discovered while investigating rustprooflabs/pgosm-flex#275.

Example

curl "https://osm2pgsql-tuner.com/api/v1?system_ram_gb=8&osm_pbf_gb=0.203&append=True&pbf_filename=colorado-latest&pgosm_layer_set=run"

Returns the following. I expected cmd to have --append, but it does not.

{
  "osm2pgsql": {
    "cmd": "osm2pgsql -d $PGOSM_CONN  --cache=1157  --slim  --output=flex --style=./run.lua  ~/pgosm-data/colorado-latest.osm.pbf", 
    "decisions": [
      {
        "desc": "Using --append, cannot use --drop", 
        "name": "Using Append", 
        "option": "--drop"
      }, 
      {
        "desc": "No reason to use --flat-nodes", 
        "name": "Not using", 
        "option": "--flat-node"
      }, 
      {
        "desc": "Set --cache to expected requirement for given PBF size.", 
        "name": "Sufficient RAM", 
        "option": "--cache"
      }
    ], 
    "osm2pgsql_append": true, 
    "osm2pgsql_cache_max": 5.28, 
    "osm2pgsql_drop": false, 
    "osm2pgsql_flat_nodes": false, 
    "osm2pgsql_limited_ram": false, 
    "osm2pgsql_noslim_cache": 1.5075, 
    "osm2pgsql_run_in_ram": false, 
    "osm2pgsql_slim_cache": 1.130625, 
    "system_ram_gb": 8.0
  }
}

[rustprooflabs]

Aha - I had forgotten that during the first run of osm2pgsql when you want to be able to use --append later, you need to just run with --slim without --drop. Later runs of osm2pgsql you use --append. It seems the tuner should require a second parameter for 1st run vs. 2nd run, b/c the 2nd (and later) run needs --append.

Add first-run parameter? Then it's only needed the first time, making subsequent runs able to use the simpler command. I think subsequent runs will outnumber 1st runs by a decent margin.

I verified that running osm2pgsql with --append on an empty database fails.

[rustprooflabs]

This has been resolved for quite a few months now. Closing.