Emit new URL('...', import.meta.url) for Wasm
#2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me! I think there's a rustfmt issue though? |
Lots of bundlers now support `new URL('...path...', import.meta.url)` as an explicit signal to specify assets that should be bundled alongside JS.
This is already supported by default in Webpack v5, Parcel v2,Vite, Snowpack and WMR, and available via a plugin - https://modern-web.dev/docs/building/rollup-plugin-import-meta-assets/ - in Rollup as well.
Emitting such pattern by default would allow all those bundlers to automatically include Wasm and generate a correct URL for `--target web` builds without any work from the user's side.
RReverser
force-pushed
the
new-url-import-meta
branch
from
17e7904
to
7ea3c39
Compare
|
Yeah, sorry about that, formatted & pushed again. |
|
@alexcrichton No rush, but do you have a planned release anytime soon by any chance? |
|
Sure, I've started one at #2468 |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of bundlers now support
new URL('...path...', import.meta.url)as an explicit signal to specify assets that should be bundled alongside JS.This is already supported by default in Webpack v5, Parcel v2, Vite, Snowpack and WMR, and available via a plugin - https://modern-web.dev/docs/building/rollup-plugin-import-meta-assets/ - in Rollup as well.
Emitting such pattern by default would allow all those bundlers to automatically include Wasm and generate a correct URL for
--target webbuilds without any work from the user's side.