Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindings for MediaStreamTrack.getCapabilities #4236

Conversation

DanielleHuisman
Copy link
Contributor

Add bindings for MediaStreamTrack.getCapabilities and stabilize MediaTrackCapabilities (which it returns).

@DanielleHuisman DanielleHuisman force-pushed the feature/mediastreamtrack-getcapabilities branch 2 times, most recently from 00f46ed to 1aadd7e Compare November 4, 2024 09:12
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't stabilize proposals that aren't in the standard class.
But the addition of MediaStreamTrack.getCapabilities() is nice, but has to be added unstably.

Let me know if you have any trouble doing that or if you have any questions!

@daxpedda daxpedda added the waiting for author Waiting for author to respond label Nov 9, 2024
@DanielleHuisman
Copy link
Contributor Author

DanielleHuisman commented Nov 10, 2024

Happy to make the change.

Just curious: what makes MediaStreamTrack stable, but not MediaTrackCapabilities? What specification or part of the specification indicates this?

@daxpedda
Copy link
Collaborator

Just curious: what makes MediaStreamTrack stable, but not MediaTrackCapabilities?

MediaStreamTrack should never have been made stable in the first place. Hindsight is 20/20 ofc.

What specification or part of the specification indicates this?

Basically we don't stabilize anything unless it has reached the last stage: "Recommended".

There is some nuance to this, where we can stabilize earlier if we are fairly confident that no API changes are coming. This mostly depends on evaluating the proposals issue tracker and if its so widely used API changes are very unlikely as they would break the Internet.

@DanielleHuisman DanielleHuisman force-pushed the feature/mediastreamtrack-getcapabilities branch 2 times, most recently from 7cdf949 to a81e4a6 Compare November 10, 2024 18:49
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daxpedda daxpedda merged commit 97c05b5 into rustwasm:main Nov 11, 2024
41 checks passed
@DanielleHuisman DanielleHuisman deleted the feature/mediastreamtrack-getcapabilities branch November 11, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author Waiting for author to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants