Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump up the wasm-bindgen version in test? #519

Closed
huangjj27 opened this issue Jan 20, 2019 · 2 comments
Closed

bump up the wasm-bindgen version in test? #519

huangjj27 opened this issue Jan 20, 2019 · 2 comments

Comments

@huangjj27
Copy link
Member

💡 Feature description

I notice that different test use a different version of wasm-bindgen, I think we can use the same version(I mean always the newest version) of wasm-bindgen, so that ALL THE TEST would use the same cache

💻 Basic example

the test that use fixture has locked the wasm-bindgen and wasm-bindgen-test to version 0.2.21,(for example, it_should_build_js_hello_world_example) while other test that generates its fixture (for exmaple, build_with_and_without_wasm_bindgen_debug) may use just the auto-patching version config of 0.2.
that means we have to download at least 2 version of wasm-bindgen cache for testing, and that spends a lot of time (especially for worker in country with network inspection where slow down github).

but if we bump up the wasm-bindgen version of fixture to 0.2, we can use the same cache and will only fetch wasm-bindgen only one time.

related to #447

@ashleygwilliams
Copy link
Member

@huangjj27 i'd happily accept a PR for this- this is a good catch! thanks for filing an issue!

@ashleygwilliams
Copy link
Member

closing as we've landed #526 via #554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants