Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected panics should still print the full panic message #562

Closed
alexcrichton opened this issue Mar 4, 2019 · 1 comment · Fixed by #601
Closed

Unexpected panics should still print the full panic message #562

alexcrichton opened this issue Mar 4, 2019 · 1 comment · Fixed by #601
Assignees
@drager
Labels
current release current todo items enhancement New feature or request PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx
Milestone
0.8.0

Comments

@alexcrichton
Copy link
Contributor

Unexpected panics are unfortunate but they're currently covered up and written out to an auxiliary file. This makes panics in CI difficult to debug, especially at a glance, as CI builders are likely not uploading those files.

wasm-pack should still print something to the console indicating what sort of error just happened.
@ashleygwilliams ashleygwilliams added enhancement New feature or request help wanted Extra attention is needed to-do stuff that needs to happen, so plz do it k thx PR welcome current release current todo items labels Mar 7, 2019
@ashleygwilliams ashleygwilliams added this to the 0.8.0 milestone Mar 14, 2019
@drager
Copy link
Member

drager commented Mar 20, 2019

I will start working on this.

@ashleygwilliams ashleygwilliams removed the help wanted Extra attention is needed label Mar 20, 2019
@drager drager mentioned this issue Mar 23, 2019
Merged
@ashleygwilliams ashleygwilliams added PR attached there's a PR open for this issue and removed PR welcome labels Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drager drager

Labels
current release current todo items enhancement New feature or request PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

feat: Print unexpected panics to standard error drager/wasm-pack
3 participants
@alexcrichton @ashleygwilliams @drager