Fix issue with sampling without replacement #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix uniform sampling is not guaranteed, over-representing the first combination of neighbors, and not sampling the last possible combination.
This PR ensures all neighbor combinations are considered during sampling, by extending the range of possible indices to include the last element.
Referencing to the example showcased in #385, using this change the sampling distribution is now:
Closes #385.