Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard codings #2147

Open
markoaamunkajo opened this issue Sep 5, 2024 · 1 comment
Open

Remove hard codings #2147

markoaamunkajo opened this issue Sep 5, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@markoaamunkajo
Copy link
Collaborator

markoaamunkajo commented Sep 5, 2024

Description:

Because these subscription infos are now available, we should start adjusting the apps to follow them and remove the hard codings.

Android card: ruuvi/com.ruuvi.station#1313
Web: ruuvi/com.ruuvi.station.webui#441


Sensor data contains subscription/feature info:

{
                "owner": "otso@ruuvi.com",
                "sensor": "C8:1C:8A:4E:42:17",
                "name": "Saarvahtra chimney 4217",
                "picture": "https://prod-sensor-profile-pictures.s3.eu-central-1.amazonaws.com/dde2aa98-5f51-4274-980c-37f83c55e74a.jpg",
                "public": false,
                "canShare": true,
                "offsetTemperature": 0,
                "offsetHumidity": 0,
                "offsetPressure": 0,
                "customProfile": false,
                "subscription": {
                    "subscriptionName": "Business",
                    "maxClaims": 50,
                    "maxShares": 80,
                    "maxSharesPerSensor": 10,
                    "maxHistoryDays": 1096,
                    "maxResolutionMinutes": 1,
                    "emailAlertAllowed": true,
                    "pushAlertAllowed": true,
                    "telegramAlertAllowed": true,
                    "delayedAlertAllowed": true,
                    "pdfExportAllowed": true,
                    "offlineAlertAllowed": true,
                    "isActive": true,
                    "endAt": "2026-07-24T10:35:42.000Z"
                },
@markoaamunkajo
Copy link
Collaborator Author

Moved to backlog, needs better specification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants