Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to Typescript #1

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Refactor to Typescript #1

merged 3 commits into from
Mar 29, 2019

Conversation

khaosdoctor
Copy link
Contributor

Refactoring to Typescript

@khaosdoctor
Copy link
Contributor Author

Can we merge this?

@rwillians
Copy link
Owner

hey @khaosdoctor sorry, hadn't seen it 'till now

@@ -5,3 +5,4 @@ node_modules
.node_repl_history
.nyc_output
npm-debug.log*
dist/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insure feed line

(I'll add an .editorconfig after merging this)

"license": "MIT",
"bugs": {
"url": "https://github.com/rwillians/express-rescue/issues"
},
"homepage": "https://github.com/rwillians/express-rescue#readme",
"devDependencies": {
"@types/express": "^4.16.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add typescript as dev dependency

@rwillians
Copy link
Owner

rwillians commented Mar 29, 2019

Meh, nevermind I'll add those changes before publishing

@rwillians rwillians merged commit d1627df into rwillians:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants