Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for --updateSnapshot #53

Open
tmquinn opened this issue Dec 7, 2018 · 5 comments
Open

add support for --updateSnapshot #53

tmquinn opened this issue Dec 7, 2018 · 5 comments

Comments

@tmquinn
Copy link

tmquinn commented Dec 7, 2018

No description provided.

@rwjblue
Copy link
Owner

rwjblue commented Dec 7, 2018

Say more? How would like to use it, what would that look like?

@tmquinn
Copy link
Author

tmquinn commented Dec 7, 2018

Similar to the jest --updateSnapshot. It would provide a way to update .output test fixtures with the currently rendering version of the .input.

jest provides a menu selection to choose which fixtures you would like to update, as described here: https://jestjs.io/docs/en/snapshot-testing#updating-snapshots

@dogoku
Copy link
Contributor

dogoku commented Dec 14, 2018

That's something that jscodeshift needs to do first. See facebook/jscodeshift#135

Once they update their testUtils to generate tests using snapshots instead of their custom way, then it would be easy to simply pipe the argument to jest

@rwjblue
Copy link
Owner

rwjblue commented Sep 30, 2019

I think we can do it actually. @Turbo87 did something similar over in ember-codemods/ember-angle-brackets-codemod#138.

@Hypnosphi
Copy link

Hypnosphi commented Oct 21, 2019

PR fixing this: facebook/jscodeshift#297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants