Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container memory leak #28

Closed
bobisjan opened this issue Jul 17, 2018 · 1 comment
Closed

Container memory leak #28

bobisjan opened this issue Jul 17, 2018 · 1 comment

Comments

@bobisjan
Copy link
Contributor

Hi,

based on the @ryanto's video https://embermap.com/topics/memory-leaks/do-i-have-a-memory-leak (thanks), I've found that this add-on is leaking container in tests in our application.

I've created this branch https://github.com/bobisjan/ember-memory-leaks/tree/ember-angle-bracket-invocation-polyfill, which reproduces the issue.

new app without add-on

screen shot 2018-07-17 at 13 33 56

new app with add-on

screen shot 2018-07-17 at 13 37 58

I'll try to deep dive into this, but I'm not familiar with these internals 🙈.

Thanks for this add-on 🤩.
@bobisjan
Copy link
Contributor Author

It looks that the problem is with assignment of _splattributes onto global BUILTIN_MODIFIERS.

@bobisjan bobisjan mentioned this issue Jul 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobisjan