Expose a rake task to npm install
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assumes that the `package.json` includes:
```json
"tasks": {
"postinstall": "bower install"
}
```
So that we only depend on a global `npm` installation (not `npm` and
`bower`)
|
@seanpdoyle This looks really promising. I'm going to test this today or tomorrow and talk to @rwz about it. /cc @rwz |
|
Great! I really dislike the fact that you need to depend on |
| @@ -25,10 +25,18 @@ def non_production? | |||
| !Rails.env.production? && Rails.configuration.consider_all_requests_local | |||
| end | |||
|
|
|||
| def inject_install_dependencies_task! | |||
There was a problem hiding this comment.
Could we move the definition if this task into a separate file? Kind if like the way it's described here
|
Looks good to me! |
|
👍 |
* Extract task definition into `.rake` file according to http://blog.nathanhumbert.com/2010/02/rails-3-loading-rake-tasks-from-gem.html * invoke `npm` with `Helpers.which`
rwz
added a commit
that referenced
this pull request
Jan 16, 2015
Expose a rake task to `npm install`
|
Yay! Now I guess we need to describe this process in README somehow. |
|
Thanks for PR @seanpdoyle |
|
@seanpdoyle Yeah, thanks! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumes either:
boweris a globally accessible commandpackage.jsonincludes:Corresponds to #33