-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix known issues, add other token types support #23
Conversation
🦋 Changeset detectedLatest commit: 32d974b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
5e1e605
to
f86f6d7
Compare
@JounQin |
1036358
to
563c07f
Compare
Sorry, I didn’t notice this PR before, I’ll check ASAP. |
I'm not sure how it's working and why we should support installing git repo. |
@HosseinAgha Thanks for your effort first, I have a few questions above, maybe it can be separated into a few PRs instead for discussion. For example, fixing the missing dependencies seems very correct to me. |
It is just a convenience for future contributors so they can directly install their PR branch in their projects and test their changes. {
"changesets-gitlab": "github:HosseinAgha/changesets-gitlab#head=fix-21-22"
} yarn (and npm) will run the prepack script after cloning my version of |
@HosseinAgha We have codesanbox support, see https://ci.codesandbox.io/status/rx-ts/changesets-gitlab/pr/23/builds/190422 for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address my nitpicky comments.
fix: add missing dependencies to package.json
…licate branches fix: make checkout message check for general
Thanks @JounQin ❤️ |
This resolves #21, resolves #22, resolves #24, and resolves #25.
The issue with the comment command was that the checking for the previous comment was not strict enough and it was trying to update a system note (by the MR owner). So if I pushed to the MR a system note would be generated and changesets-gitlab would accidentally try to updated that comment.
I've also added a
prepack
script so future contributors can use the raw Github repository as a dependency.I've also added a new option to provide CIJob or OAuth token (gitbeaker actually supports this), although looks like ci-job-token access is very limited so only oauth token is usable until this Gitlab MR merges.