Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The key 'name' #3

Open
yjzhux opened this issue Jan 19, 2021 · 2 comments
Open

The key 'name' #3

yjzhux opened this issue Jan 19, 2021 · 2 comments

Comments

@yjzhux
Copy link

yjzhux commented Jan 19, 2021

for i, d in enumerate(self.real_arts):
name = d['name']
realarts2id[name] = i

Hi, what does the 'name' refer to? It should be a key stored in '*.bert.pt' which is the output of PreSumm. But there is no such a key in their code. See:
https://github.com/nlpyang/PreSumm/blob/70b810e0f06d179022958dd35c1a3385fe87f28c/src/prepro/data_builder.py#L320-L322

Another question: what are the hyper-parameters when you use PreSumm to extract language features? Thanks.

@rxtan2
Copy link
Owner

rxtan2 commented Jan 25, 2021

You can modify PreSumm to add in the name of the article when extracting the features.

what are the hyper-parameters when you use PreSumm to extract language features?

I am not sure about this. I don't recall setting any hyperparameters. All you have to do to get the language features is follow the steps in Option 2: process the data yourself.

@yjzhux
Copy link
Author

yjzhux commented Jan 25, 2021

Thanks. That's what I did.

I followed their steps and made the following changes for the hyper-parameters:

'-min_src_nsents', default=1
'-min_src_ntokens_per_sent', default=1
'-min_tgt_ntokens', default=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants