-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly check optional arguments if we are NOT loading FASTQ, and warn or throw. #1
Conversation
previous code path required -force_load_fastq flag
useful for merging paired-fastq files and a corresponding "unpaired" reads file
previously crashed on fastq reads
5d49a17
to
e6ed00b
Compare
I see what you mean now: a consequence of I think that the cases you're guarding against here are worth checking but are also just a few of the cases that we maybe should check against (from a quick survey of all the available options to So, I'm inclined to think of this as work for another PR: "validate Let me know if you think I'm mistaken about the existence of this problem predating bigdatagenomics#831 or if you think that the args I've introduced there are pushing us over the edge of needing to do this kind of validation, either just to the flags I've added or to all the flags to |
e6ed00b
to
47ebc12
Compare
Agree with 100% of what you said! Let's push this to another PR; I've filed an issue: bigdatagenomics#841. |
Closing in favor of bigdatagenomics#841. |
tweak implicits in AlignmentRecordRDDFunctions
LMK your thoughts here. I don't feel strongly one way or the other about adding this code in, but I thought it might be a useful check to have.