Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI breaks for pull requests (No API token) #10

Closed
ryankurte opened this issue Apr 22, 2017 · 4 comments
Closed

CI breaks for pull requests (No API token) #10

ryankurte opened this issue Apr 22, 2017 · 4 comments
Assignees

Comments

@ryankurte
Copy link
Owner

Pull requests don't get loaded with an API token, so all tests fail against PRs (see #9).

Current solution is to create a local branch for the pull request which then tests run against, but it's a bit frustrating for contributors not to be able to test the PR.

@Aravind741 could you please try adding your own mapbox API keys to your fork as an environmental variable through the travis settings (rather than the .travis.yml)?
Settings URL should be something like https://travis-ci.org/aravind741/go-mapbox/settings

screen shot 2017-04-23 at 10 50 55 am

If that sorts out the PR test problem I will add it to the readme.

@ryankurte ryankurte self-assigned this Apr 22, 2017
@ryankurte
Copy link
Owner Author

Otherwise the option is for a contributor / admin to run:

git checkout -b USER-PR master
git pull git://github.com/USER/go-mapbox.git PR
git push origin USER-PR

Which updates the push build in the github PR view, but not the PR build.
Then you have to admin override the PR (with one test passing) to merge it :-/

@thearavind
Copy link
Contributor

@ryankurte Adding the token to my travis account is not solving the problem

I have closed the PR and reopened it again to re run the tests

image

@ryankurte
Copy link
Owner Author

Thanks for trying it out! Will have to inquire with travis-ci how to resolve this.

PR #9 manually merged for now, and will have to continue with that till there's a better solution.

@ryankurte
Copy link
Owner Author

closing for inactivity, will worry about this again if it's a regular problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants