-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MonaspiceNe Nerd Font Mono ss06 causing characters to overlay on each other #1503
Comments
Thanks for reporting with very good details! I believe I instantly know from your description what the problem is: The problem I see is that they would need to invest a considerable amount of time to 'fix' the ligatures; it is unclear for me if they will ever get the time for that. The ligs work, somehow, with some limitations, so why spend time and money ... Let me think a bit about the issue and if there is any generic way we can avoid the problem. P.S. Do you not see [1a] in VScode? With the non-NerdFontMono patched versions or the unpatched one? [1a] https://www.github.com/githubnext/monaspace/issues/115 Links without backlink as this Issue is not really helpful over there |
For 1a, I notice the same behavior that's in that issue when using the non-NFM patched version, so that's definitely an issue with Monaspace. I do notice that the behavior is a bit different with the NFM variant though. To fully explain the issue (though this is not a NFM issue, but there are differences between the two variants): With non-NFM (normal Monaspace Neon), while the cursor appears after the arrow, in reality the cursor is between the When pressing the right arrow key, you actually need to press it twice to pass through the With the NFM patched version (MonaspiceNe Nerd Font Mono), while the behavior is almost entirely the same, the difference is that the cursor is now stuck in the middle of the two characters: As for the behavior noted in this issue, I've only noticed that behavior with the NFM variants of the fonts. If this issue can't be solved from the Nerd Font side, feel free to close the issue. This does seem like an issue with Monaspace itself at the very least. Also, just tested with MonaspiceNe Nerd Font (non-Mono) and it has the same behavior as Monaspace (non-NF) |
Well, that all is the problem because Monaspace's idea of how to create the ligs. But then, why should I invest time there, I can not fix all and everything. I already now have no time left. |
To be clear - I'm not saying that it needs to be fixed here. Just wanted to report it as an issue, feel free to close as "wont fix" if you feel like it falls into Monaspace's domain to fix. |
It does indeed. (which is still not fixed upstream despite the pending PR that they even said they will merge). I mark this as wontfix as you suggested but keep it open to not forget it. Maybe I have to attend some boring meeting and can work on it then 😬 |
@allcontributors please add @TehPers for bug |
I've put up a pull request to add @TehPers! 🎉 |
@Stealthii It's my first time running the font patcher myself, so I'll include the command I ran when checking out the PR branch: docker run --rm -v /path/to/nerd-fonts/src/unpatched-fonts/Monaspace:/in:Z -v /path/to/nerd-fonts/patched-fonts/Monaspace:/out:Z nerdfonts/patcher --mono --complete After uninstalling the old font, running the above command, and reinstalling MonaspiceNe Nerd Font Mono (all of the generated |
See second edit, but this doesn't appear to be a NF-related problem. @Stealthii I've been using the updated font (MonaspiceNe Nerd Font Mono, generated from your PR), and I found an interesting related issue with a different stylistic set. I know that your PR is only addressing updating Monaspace to v1.100, but just including it here since it seems to be related. This may also be an issue with vscode. To be honest, I'm not entirely sure how to debug where this issue comes from, so I'll include screenshots here, and I can open up an issue on the appropriate repository if anyone has suggestions. Using This is without red squigglies: It's a bit hard to try to reproduce this with I'm not really sure why this only happens when there are red squigglies. I couldn't reproduce it with yellow squigglies: (If you're trying to reproduce, the first images used Rust, third image was Rust but on the first line as a messed up shebang, and the last one was Markdown) Edit: Here's with the Edit 2: I started investigating this further, and this is with Monaspace Neon v1.100 and v1.101 respectively (same issue): v1.000 doesn't seem to have the ligature, which is likely why I wasn't seeing this before: For fun, I also tried Fira Code with ligatures enabled (since it has a ligature for This seems to me to be an issue with Monaspace itself and not with NF, and my guess is it isn't a vscode issue either since Fira Code seems to be working fine. Maybe I'll open an issue on Monaspace about this. |
Duplicate of #1631, fixed.
What does that mean? Probably like #1515? "Bold" letters come in from another font, and there is most likely nothing Nerd Fonts can do. Hmm, well, at least if that is what you mean, report in 1515, so I have all comments in one Issue. Edit: Add mention of fixed ShareTech font set for download |
Possibly related: githubnext/monaspace#190 |
I should probably mention this, but the original issue I posted seems to be resolved by #1630 as far as I can tell. MonaspiceNe no longer has the overlapping characters. I opened an issue on Monaspace for the other issue I came across. That does not seem to be a NF issue since it seems to happen with base Monaspace as well. If we want to continue to use this issue thread for other instances of overlapping characters, then feel free, but I just wanted to make it clear that my issue is resolved by that PR at least. |
🗹 Requirements
🎯 Subject of the issue
Experienced behavior:
When enabling
ss06
on MonaspiceNe Nerd Font Mono, characters after consecutive#
s end up overlayed with the#
s:I was able to confirm that MonaspiceNe Nerd Font and MonaspiceNe Nerd Font Propo have the correct behavior.
Screenshot is from vscode, but I was able to reproduce the issue in Windows Terminal as well:
Expected behavior:
The same behavior as Monaspace Neon/MonaspiceNe Nerd Font/MonaspiceNe Nerd Font Propo:
For comparison, with
ss06
disabled:Example symbols:
The main symbol I've noticed affected is
#
. I haven't noticed any others, but as far as I know,ss06
only affects#
.🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf
)?MonaspiceNeNerdFontMono-*.otf
- as far as I can tell, affects all variants of it. Confirmed with Light and Regular at leastMonaspace.zip
, also testedMonaspace.tar.xz
iterm2
,urxvt
,gnome
,konsole
)?★ Screenshots (Optional)
settings.json
for Windows Terminal:Copyable settings:
The text was updated successfully, but these errors were encountered: