Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Adobe Source Code Pro] Powerline Symbols not aligned. #60

Closed
beanaroo opened this issue Mar 1, 2016 · 5 comments
Closed

[Adobe Source Code Pro] Powerline Symbols not aligned. #60

beanaroo opened this issue Mar 1, 2016 · 5 comments

Comments

@beanaroo
Copy link

beanaroo commented Mar 1, 2016

I believe this is due to the switch from Sauce Code Pro to Adobe Source Code Pro by issue #33.
I'm not sure if nerd fonts patches over the existing glyphs.
This could also be an upstream issue, as shown here.

@ryanoasis
Copy link
Owner

It should not be patching over the powerline glyphs unless you run the patcher with the --powerline flag.

I just checked the script logic that generates all the patched fonts and it should not be overriding the powerline symbols for Hack or Source Code Pro. However it is possible the conditional is not catching the proper case (I would need to run it and see).

@beanaroo
Copy link
Author

beanaroo commented Mar 2, 2016

The problem exists without patching the font, so I believe it could be upstream.

@ryanoasis
Copy link
Owner

Interesting thanks. I'll have to keep my eyes open for developments.

@ryanoasis
Copy link
Owner

Things have been looking pretty good for a while now on powerline glyph alignments and also yes Nerd Fonts does not by default patch over existing glyphs (there is even a specific config for powerline).

Here are some latest results of Sauce Code Pro at different sizes with v1.1.0:

13pt

selection_014

9pt

selection_015

16pt

selection_016

Closing for now. Thanks. 😄

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants