Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components in the iFrame refers to the wrong window object #40

Closed
micky2be opened this issue Apr 11, 2016 · 3 comments
Closed

Components in the iFrame refers to the wrong window object #40

micky2be opened this issue Apr 11, 2016 · 3 comments

Comments

@micky2be
Copy link

When using react-frame-component I noticed that when I wrote my own listeners on the window object for component in the iFrame it will unfortunately refers to the parent window.

This can be very problematic when using third party components.

@martijnvermaat
Copy link

Not sure what you're doing exactly, but would a strategy like this help you?

react-bootstrap/react-bootstrap#463

@ryanseddon
Copy link
Owner

This is a tough one for 3rd party components but for your own you can do as @martijnvermaat suggested and use ownerDocument to get the right context.

@darthtrevino
Copy link
Collaborator

The Document and Window are now passed down available as context values. I think this problem is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants