feat: support custom alphabet #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this great package. I don't expect we need any additional tests. |
ryasmi
approved these changes
May 3, 2024
There was a problem hiding this comment.
Thanks for this @seia-soto 👍 Apologies for my slow review, I didn't get a notification for this. I think my approval here will trigger the Actions and will probably show that we need to add tests to this PR to meet the coverage requirements.
|
Sorry @seia-soto this has been waiting for approval for more than 30 days, so I'm not able to approve the workflow to run, could you please push an empty commit to the branch so I can approve that? git push --allow-empty -m "ci: Triggers CI" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #44