From 19fd24eff894800b8cf06001df27e650d254123a Mon Sep 17 00:00:00 2001 From: Teemu Rytilahti Date: Tue, 15 Nov 2022 17:55:05 +0100 Subject: [PATCH] Add todos, remove breakpoint call for binary_sensor --- homeassistant/components/xiaomi_miio/binary_sensor.py | 4 ++-- homeassistant/components/xiaomi_miio/number.py | 4 ++-- homeassistant/components/xiaomi_miio/sensor.py | 3 +++ 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/xiaomi_miio/binary_sensor.py b/homeassistant/components/xiaomi_miio/binary_sensor.py index ed2780df6d86aa..8f4b96a6d4fe71 100644 --- a/homeassistant/components/xiaomi_miio/binary_sensor.py +++ b/homeassistant/components/xiaomi_miio/binary_sensor.py @@ -25,10 +25,10 @@ async def async_setup_entry( coordinator = hass.data[DOMAIN][config_entry.entry_id][KEY_COORDINATOR] for sensor in device.sensors().values(): if sensor.type == bool: - breakpoint() if getattr(coordinator.data, sensor.property) is None: # TODO: we might need to rethink this, as some properties (e.g., mop settings) - # are none depending on the device mode + # are none depending on the device mode at least for miio devices + # maybe these should just default to be disabled? _LOGGER.debug("Skipping %s as it's value was None", sensor.property) continue diff --git a/homeassistant/components/xiaomi_miio/number.py b/homeassistant/components/xiaomi_miio/number.py index 3acd0dc24d71c4..9588fc88886d30 100644 --- a/homeassistant/components/xiaomi_miio/number.py +++ b/homeassistant/components/xiaomi_miio/number.py @@ -3,6 +3,8 @@ import logging +from miio.descriptors import SettingType + from homeassistant.config_entries import ConfigEntry from homeassistant.core import HomeAssistant from homeassistant.helpers.entity_platform import AddEntitiesCallback @@ -28,8 +30,6 @@ async def async_setup_entry( # Handle switches defined by the backing class. for setting in device.settings().values(): - from miio.descriptors import SettingType - if setting.type == SettingType.Number: _LOGGER.debug("Adding new number setting: %s", setting) entities.append(XiaomiNumber(device, setting, config_entry, coordinator)) diff --git a/homeassistant/components/xiaomi_miio/sensor.py b/homeassistant/components/xiaomi_miio/sensor.py index 52ac899b29d7e0..38ae1e52a10fc8 100644 --- a/homeassistant/components/xiaomi_miio/sensor.py +++ b/homeassistant/components/xiaomi_miio/sensor.py @@ -29,6 +29,9 @@ async def async_setup_entry( for sensor in device.sensors().values(): if sensor.type != bool: if getattr(coordinator.data, sensor.property) is None: + # TODO: we might need to rethink this, as some properties (e.g., mop settings) + # are none depending on the device mode at least for miio devices + # maybe these should just default to be disabled? _LOGGER.debug("Skipping %s as it's value was None", sensor.property) continue