Random blocks and key repeat #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for more another great contribution @mmssouza. I'll review this in soon carefully, but so far seems good points! |
ryukinix
reviewed
Dec 17, 2018
| @@ -107,6 +118,15 @@ Block const BLOCK_EMPTY = { | |||
| {0, 0, 0}, | |||
| }; | |||
|
|
|||
| /*const Block *Blocks[] = { BLOCK_T, | |||
| static int counter = 1; | ||
| switch (counter % 7) { | ||
| case 0: | ||
| current_block = rand() % BLOCK_NUM; |
main.c
Outdated
| INT2F = 0; | ||
| key = KEY_ROTATE; | ||
| } | ||
| seed[seed_idx] = val; |
There was a problem hiding this comment.
Nice seed provider. Since the TM2 timer has been used as part of the seed, I think this will generate visually a sufficient random behavior for block generation.
The unique problem I saw is the first game after the microcontroller starts. If I undestand correctly, in this moment the seed will be always the same, right? Thus the first piece of a game started from scratch will always be the same.
After the first piece we will get a pseudo-random behavior which I think is good enough.
- key_management(): poll keys instead of using interrupts. Implemented key debounce and key repetition features. Check for left and right collisions prior block rotation. - fall_row_until() and check_game_over(): reimplemented for better performance. - game_manager(): case 1 in state machine modified. - interrupt code moved to stay after the main loop. - implemented a seeding and random block insersion strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Manoel,
This pull request implements both a strategy for random blocks insertion and the command repeat feature when keys are hold pressed.
Best regards,
Marcelo