fix: delay sending diagnotics request

It seems that it halts checker for some time and it cannot answer another requests.
s-panferov · Aug 14, 2017 · 90022ae · 90022ae
1 parent 5304203
commit 90022ae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/checker/checker.ts b/src/checker/checker.ts
@@ -132,7 +132,7 @@ export class Checker {
         } as RemoveFile.Request);
     }
 
-    getDiagnostics(): any {
+    getDiagnostics(): Promise<any> {
         return this.req({
             type: 'Diagnostics'
         } as Diagnostics.Request);

diff --git a/src/instance.ts b/src/instance.ts
@@ -458,7 +458,7 @@ function setupAfterCompile(compiler, instanceName, forkChecker = false) {
             });
 
         const timeStart = +(new Date());
-        const diag = instance.loaderConfig.transpileOnly
+        const diag = () => instance.loaderConfig.transpileOnly
             ? Promise.resolve()
             : instance.checker.getDiagnostics()
                 .then(diags => {
@@ -479,10 +479,10 @@ function setupAfterCompile(compiler, instanceName, forkChecker = false) {
         files
             .then(() => {
                 if (asyncErrors) {
-                    // Don't wait for diags in watch mode
+                    diag(); // Don't wait for diags in watch mode
                     return;
                 } else {
-                    return diag;
+                    return diag();
                 }
             })
             .then(() => callback())