1.95 release

[gaul]

Let's run one more release that is compatible with CentOS 7 since we will drop support for it in #2469. I would like to finish off work on the static lock checking since this seems to reveal a bunch of concurrency bugs but otherwise I don't think we have any other outstanding PRs.

[ggtakec]

I agree to the 1.95 release.
Let's make this the last version for CentOS 7.

@juliogonzalez
Is it possible to release for CentOS 7?
My test code that I created for CentOS 7 is no longer buildable on Github Actions, so I can't test it with CI.

[juliogonzalez]

I agree to the 1.95 release. Let's make this the last version for CentOS 7.

@juliogonzalez Is it possible to release for CentOS 7? My test code that I created for CentOS 7 is no longer buildable on Github Actions, so I can't test it with CI.

Possible: Yes

Desiderable: Not so much without tests, IMHO.

I wil try to have a look in the next days to see if I can find why this is failing, as it should not. My suspect is something around uses: actions/checkout@v3, but not sure right now of what's going on. Maybe it won't be hard to figure it out.

[ggtakec]

@juliogonzalez
Sorry for my poor explanation.

The reason it's failing is because Github Actions' actions/checkout@v3 can't checkout the source code, and this is a problem specific to GHA.
(It worked right after EOL, but started failing after that)
There should be no problem building the source code.

[juliogonzalez]

@juliogonzalez Sorry for my poor explanation.

The reason it's failing is because Github Actions' actions/checkout@v3 can't checkout the source code, and this is a problem specific to GHA. (It worked right after EOL, but started failing after that) There should be no problem building the source code.

I see.

But if you create 1.95 from master (and not from the point where you branched to try fix the tests for CentOS7), that would mean releasing with commits that were not really tested for CentOS7. And in this case it would be better to avoid the release.

Let me play a little bit with your branch to see if I can get a fix, before we take a decision. I will come back to you in a few days, probably during the weekend, or shortly after.

[ggtakec]

I posted PR #2497 to restore CentOS 7 to CI(Github Actions).

@juliogonzalez
The reason why actions/checkout execution was failing was because it was changed to use nodejs 20(CentOS 7 needs nodejs 16).
To avoid this, the ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION(=true) environment variable is set.
Reference: actions/checkout#1809

@gaul
Could you review this PR #2497 ?
The code added in this PR (only CI-related) can be deleted after the release.
I would like to merge this PR and prepare it for release 1.95.