-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.95 release #2496
Comments
I agree to the 1.95 release. @juliogonzalez |
Possible: Yes Desiderable: Not so much without tests, IMHO. I wil try to have a look in the next days to see if I can find why this is failing, as it should not. My suspect is something around |
@juliogonzalez The reason it's failing is because Github Actions' actions/checkout@v3 can't checkout the source code, and this is a problem specific to GHA. |
I see. But if you create 1.95 from master (and not from the point where you branched to try fix the tests for CentOS7), that would mean releasing with commits that were not really tested for CentOS7. And in this case it would be better to avoid the release. Let me play a little bit with your branch to see if I can get a fix, before we take a decision. I will come back to you in a few days, probably during the weekend, or shortly after. |
I posted PR #2497 to restore CentOS 7 to CI(Github Actions). @juliogonzalez @gaul |
Let's run one more release that is compatible with CentOS 7 since we will drop support for it in #2469. I would like to finish off work on the static lock checking since this seems to reveal a bunch of concurrency bugs but otherwise I don't think we have any other outstanding PRs.
The text was updated successfully, but these errors were encountered: