Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Do not delete object by version #576

Closed
votdev opened this issue Jun 12, 2023 · 0 comments · Fixed by s3gw-tech/s3gw-ui#204
Closed

UI: Do not delete object by version #576

votdev opened this issue Jun 12, 2023 · 0 comments · Fixed by s3gw-tech/s3gw-ui#204
Assignees
@votdev
Labels
area/ui User Interface kind/bug Something isn't working
Milestone
v0.18.0

Comments

@votdev
Copy link
Contributor

votdev commented Jun 12, 2023

Thanks to the changes done via aquarist-labs/ceph#153 handling object versions seem to be improved. Because of this changes the object deletion behaves different than expected; a versioned object that has been deleted is completely wiped instead of creating a new 'deleted' version. Because of that it is not possible to restore them from previous version.

To fix that behaviour the UI should not set the object version explicitly when deleting.
@votdev votdev added kind/bug Something isn't working area/ui User Interface labels Jun 12, 2023
@votdev votdev added this to the v0.18.0 milestone Jun 12, 2023
@votdev votdev self-assigned this Jun 12, 2023
@votdev votdev added this to S3GW Jun 12, 2023
@github-project-automation github-project-automation bot moved this to Backlog in S3GW Jun 12, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Jun 12, 2023
@jhmarina jhmarina moved this from Backlog to To Do in S3GW Jun 12, 2023
votdev referenced this issue in votdev/s3gw-ui Jun 14, 2023
@votdev
UI: Improve object deletion
78b979e 
Fixes: https://github.com/aquarist-labs/s3gw/issues/550
Fixes: https://github.com/aquarist-labs/s3gw/issues/576

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev mentioned this issue Jun 14, 2023
Merged
3 tasks
votdev referenced this issue in votdev/s3gw-ui Jun 14, 2023
@votdev
UI: Improve object deletion
6e4f2e1 
Fixes: https://github.com/aquarist-labs/s3gw/issues/550
Fixes: https://github.com/aquarist-labs/s3gw/issues/576

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev moved this from To Do to In Review 👀 in S3GW Jun 14, 2023
votdev referenced this issue in votdev/s3gw-ui Jun 14, 2023
@votdev
UI: Improve object deletion
acce19f 
Fixes: https://github.com/aquarist-labs/s3gw/issues/550
Fixes: https://github.com/aquarist-labs/s3gw/issues/576

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev removed the triage/waiting Waiting for triage label Jun 14, 2023
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done in S3GW Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@votdev votdev

Labels
area/ui User Interface kind/bug Something isn't working
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging a pull request may close this issue.

UI: Improve object deletion votdev/s3gw-ui
1 participant
@votdev