rgw/sfs: specifying a region triggers location constraint errors

[jecluis]

We've had reports that users require specifying --rgw-relaxed-region-enforcement to be able to create buckets.

I suspect this happens when the user specifies a region where to create said bucket.

During RGWCreateBucket::execute() we hit a series of checks for whether a location_constraint is set, and, if so, it relies on the SAL driver to assess whether said location_constraint is valid. Given we have only stubbed zone/zonegroup APIs, we are likely hitting this issue by returning false on has_zonegroup_api() or a similar function.

This can potentially be addressed by assuming that whatever region the user specifies is valid, given we don't particularly care about whether a region is set or not.

[jecluis]

Couldn't reproduce this with boto3, but managed to do it with the rust sdk.

For a request like this:

url: http://127.0.0.1:7480/foobar-a4cpf/
method: PUT
header content-type: application/xml
header content-length: 154
header user-agent: aws-sdk-rust/1.0.1 os/linux lang/rust/1.74.0-nightly
header x-amz-user-agent: aws-sdk-rust/1.0.1 api/s3/1.4.0 os/linux lang/rust/1.74.0-nightly
body len: 154
body:
<CreateBucketConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><LocationConstraint>af-south-1</LocationConstraint></CreateBucketConfiguration>
---- 8< ----
Error: service error

We get rgw complaining about a location constraint not being met:

2023-11-29T08:37:19.135+0000 7f0ecda356c0  2 req 0 0.004000047s s3:create_bucket normalizing buckets and tenants               
2023-11-29T08:37:19.135+0000 7f0ecda356c0 10 req 0 0.004000047s s->object=<NULL> s->bucket=foobar-a4cpf                        
2023-11-29T08:37:19.135+0000 7f0ecda356c0  2 req 0 0.004000047s s3:create_bucket init permissions                              2023-11-29T08:37:19.135+0000 7f0ecda356c0  2 req 0 0.004000047s s3:create_bucket recalculating target                          
2023-11-29T08:37:19.135+0000 7f0ecda356c0  2 req 0 0.004000047s s3:create_bucket reading permissions                           2023-11-29T08:37:19.135+0000 7f0ecda356c0  2 req 0 0.004000047s s3:create_bucket init op                                       
2023-11-29T08:37:19.135+0000 7f0ecda356c0  2 req 0 0.004000047s s3:create_bucket verifying op mask                             
2023-11-29T08:37:19.135+0000 7f0ecda356c0  2 req 0 0.004000047s s3:create_bucket verifying op permissions                      2023-11-29T08:37:19.139+0000 7f0ecda356c0  2 req 0 0.008000094s s3:create_bucket verifying op params                           
2023-11-29T08:37:19.139+0000 7f0ecda356c0  2 req 0 0.008000094s s3:create_bucket pre-executing                                 2023-11-29T08:37:19.139+0000 7f0ecda356c0  2 req 0 0.008000094s s3:create_bucket check rate limiting                           
2023-11-29T08:37:19.139+0000 7f0ecda356c0  2 req 0 0.008000094s s3:create_bucket executing                                     
2023-11-29T08:37:19.139+0000 7f0ecda356c0  5 req 0 0.008000094s s3:create_bucket NOTICE: call to do_aws4_auth_completion       
2023-11-29T08:37:19.139+0000 7f0ecda356c0 10 req 0 0.008000094s s3:create_bucket v4 auth ok -- do_aws4_auth_completion         
2023-11-29T08:37:19.139+0000 7f0ecda356c0 10 req 0 0.008000094s s3:create_bucket create bucket location constraint: af-south-1 
2023-11-29T08:37:19.139+0000 7f0ecda356c0  0 req 0 0.008000094s s3:create_bucket location constraint (af-south-1) can't be foun
d.
2023-11-29T08:37:19.139+0000 7f0ecda356c0  2 req 0 0.008000094s s3:create_bucket completing
2023-11-29T08:37:19.139+0000 7f0ecda356c0  2 req 0 0.008000094s s3:create_bucket op status=-2208
2023-11-29T08:37:19.139+0000 7f0ecda356c0  2 req 0 0.008000094s s3:create_bucket http status=400
2023-11-29T08:37:19.139+0000 7f0ecda356c0  1 ====== req done req=0x7f0fbe704448 op status=-2208 http_status=400 latency=0.00800
0094s ======

[jecluis]

turns out it's reproducible with boto3 (need to specify the CreateBucketConfiguration parameter), as well as with the aws tool:

aws --region "foobar" --endpoint-url http://127.0.0.1:7480 s3api create-bucket --bucket bucketb --create-bucket-configuration "LocationConstraint=af-south-1"

An error occurred (InvalidLocationConstraint) when calling the CreateBucket operation: The specified location-constraint is not valid