Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed function compute_content_md5 stll used in S3.py #1312

Closed
mjsaarin opened this issue Mar 6, 2023 · 2 comments
Closed

Renamed function compute_content_md5 stll used in S3.py #1312

mjsaarin opened this issue Mar 6, 2023 · 2 comments
Milestone

Comments

@mjsaarin
Copy link

mjsaarin commented Mar 6, 2023

I found out that there is sill one line in S3.py that uses compute_content_md5 instead of generate_content_md5. The diff is below.

diff  --git a/S3/S3.py b/S3/S3.py
index 9bf2e92..57275f7 100644
--- a/S3/S3.py
+++ b/S3/S3.py
@@ -1088,7 +1088,7 @@ class S3(object):
         body += '<Status>%s</Status>' % status
         body += '</VersioningConfiguration>'
         debug(u"set_versioning(%s)" % body)
-        headers['content-md5'] = compute_content_md5(body)
+        headers['content-md5'] = generate_content_md5(body)
         request = self.create_request("BUCKET_CREATE", uri = uri,
                                       headers = headers, body = body,
                                       uri_params = {'versioning': None})
@jeffwang0516
Copy link
Contributor

#1290

@fviard fviard added this to the 2.4.0 milestone Oct 20, 2023
@fviard
Copy link
Contributor

fviard commented Oct 20, 2023

Should now be resolved in Master #1340 that was merged.

@fviard fviard closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants