Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Loading the model once for all #223

Open
lelapin123 opened this issue Jan 13, 2024 · 7 comments
Open

[Feature request] Loading the model once for all #223

lelapin123 opened this issue Jan 13, 2024 · 7 comments

Comments

@lelapin123
Copy link

One of the advantage of an application that keeps running (like with a server) is that you can load the model once in the memory and make several pictures generations without having to load the model again in the memory.
This saves time.

So i would like to know if there is already a way to generate several little videos without having to reload the model again in the memory and if not (my feature request).
Make an API server that can accept requests from other software.

@Eye-01
Copy link

Eye-01 commented Jan 13, 2024

It's not an API repo, which has different objectives than a user CLI. The best you can do for now, is passing -r {number} argument to Generate, so the models are not unloaded during each seed change. Or you may fork and implement a waiting step to receive commands, but it seems for me that this adds one dimension to the programming load, meaning it will be quite a burden to follow any further CLI commands evolution.

@lelapin123
Copy link
Author

it is my version of the software or ???

I get this answer:
" No such option: -r"

How to use that ?

@Eye-01
Copy link

Eye-01 commented Jan 23, 2024

it is my version of the software or ???

I get this answer: " No such option: -r"

How to use that ?

-r or --repeats followed by a number.
To check all cli options :
animatediff generate -h

@lelapin123
Copy link
Author

It works...
There is just one problem: the things seem to be generated with the same seed.
This makes this option pretty useless.

I think this is a bug.

@Eye-01
Copy link

Eye-01 commented Jan 25, 2024

It works... There is just one problem: the things seem to be generated with the same seed. This makes this option pretty useless.

I think this is a bug.

No, it works as it should. You probably didn't pass a seed list but just a unique seed.

@lelapin123
Copy link
Author

yes but why include a --repeats command, when you can just have several seeds in the JSON (implied: i want to generate the content with these seeds) ?

@Eye-01
Copy link

Eye-01 commented Jan 25, 2024

yes but why include a --repeats command, when you can just have several seeds in the JSON (implied: i want to generate the content with these seeds) ?

The seed list is within json config file, not as a cli command.
Read How To Use section in the Readme.

  "seed": [
    341774366206100,-1,-1         # -1 means random. If "--repeats 3" is specified in this setting, The first will be 341774366206100, the second and third will be random.
  ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants