Bugfix: Using PHP 8.2 dynamic properties removed #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any progress on this? |
| @@ -251,7 +252,7 @@ function _process_tag_php($text) | |||
| '<font color="', | |||
| '</font>', | |||
| "\n ", | |||
| '� ' | |||
| '� ' | |||
There was a problem hiding this comment.
unsure what this character would be (probably some ISO-8859-1 one?!) and what it would then maybe break. Could also be a UTF-8 BOM in ISO-8859-1?!
| if (is_null($string)) | ||
| return $string; | ||
|
|
||
| return pg_escape_string($serendipity['dbConn'], $string); |
There was a problem hiding this comment.
Wasn't this another issue/patch? Unsure how it affects existing setups...?
There was a problem hiding this comment.
Yes, there sadly seem to be some commits that got mixed together, also in the other PR :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.2 removes support of dynamic class properties. Compensate the change on selected plugins.
While looking at those changes a pattern emerges.
Maybe having
$markup_elementsand$dependenciesin parent class should be a faster and cleaner fix. While at it drop usage of way-back-obsoletedlet.