Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: join-item impacts the radius of its children #1957

Closed
Suniron opened this issue Jun 8, 2023 · 4 comments
Closed

bug: join-item impacts the radius of its children #1957

Suniron opened this issue Jun 8, 2023 · 4 comments

Comments

@Suniron
Copy link

Suniron commented Jun 8, 2023

What version of daisyUI are you using?

latest (tested in documentation and in Tailwind Play)

Describe your issue

Hey there,

In the latest version of DaisyUI, the join-item class override the radius of children.

For example, if you have a badge or a btn nested in a collapse that has a join-item class, badge, and btn do have not the original rounded aspect.

Do you have a workaround for that? 🙏

What browsers are you seeing the problem on?

Chrome

Reproduction URL (optional)

https://play.tailwindcss.com/bI4RPexOut

@andre-gra
Copy link

Hi @Suniron,

maybe not the smarter solution, but you can apply directly on the btn element a rounded tailwind class in this way :

<button class="btn rounded-[--rounded-btn]">I want to be rounded 😥</button>

@Suniron
Copy link
Author

Suniron commented Jun 9, 2023

It's not easy in a real app where we have deeply nested components 🤯

@andre-gra
Copy link

Of course, you are right! Maybe you can use a customization of your btn component on your CSS file, using Tailwind's @apply directive, following daisyUI docs (point 3 of daisyui.com/docs/customize)
Using rounded-[--rounded-btn] you don't alterate any other default btn styles, because you only reapply its own rounded-btn style.

It' s only a workaround, but it could works...even if I don't know all the details of your real app.

@saadeghi
Copy link
Owner

Fixed in 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants