Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency eslint-plugin-unicorn to v50 #1077

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 29, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-plugin-unicorn ^48.0.1 -> ^50.0.1 age adoption passing confidence

Release Notes

sindresorhus/eslint-plugin-unicorn (eslint-plugin-unicorn)

v50.0.1

Compare Source

Fixes
  • no-unnecessary-polyfills: Fix missing dependency error (#​2242) 3df1606

v50.0.0

Compare Source

New rules
Improvements
Fixes

v49.0.0

Compare Source

Improvements
  • expiring-todo-comments: Support monorepos (#​2159) ac51d40
  • prefer-module: Allow module as TSIndexSignature names or TSTypeAliasDeclaration ids (#​2209) ea94b3b
  • Support RegExp v flag (#​2195) 28e7498
  • prefer-event-target: Ignore EventEmitter from @angular/core and eventemitter3 (#​2197) 1629ebe

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71ecedb) 100.00% compared to head (631afed) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1077   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines           57        57           
  Branches         2         2           
=========================================
  Hits            57        57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-plugin-unicorn 50.0.1 None +0 657 kB fisker

@renovate renovate bot force-pushed the renovate/eslint-plugin-unicorn-50.x branch from eb041ba to 843be8d Compare December 29, 2023 22:55
@renovate renovate bot force-pushed the renovate/eslint-plugin-unicorn-50.x branch from 843be8d to 631afed Compare December 30, 2023 00:08

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 2

Change summary by file extension:
.json : +1 -1
.lock : +0 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@renovate renovate bot merged commit 7d064dd into main Dec 30, 2023
12 checks passed
@renovate renovate bot deleted the renovate/eslint-plugin-unicorn-50.x branch December 30, 2023 04:26
github-actions bot added a commit that referenced this pull request Dec 30, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> 7d064dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants