build: use NPM packages instead of git submodules

[andreivladbrg]

Switches from installing v2-core as a git module to installing it as a NPM package.

[PaulRBerg]

Thanks, this is great.

We can also install forge-std as a Node.js package from GitHub.

[andreivladbrg]

We can also install forge-std as a Node.js package from GitHub.

I've asked about this here

My personal opinion is that we could leave the forge-std to be the only dependency installed as a git module because it can be considered a "std" library in Foundry projects.

[PaulRBerg]

I wasn't able to use Forge Std as a Node.js package, so I think this is not a question of preference but of necessity. We will keep installing Forge Std from git submodules.

foundry-rs/forge-std#208 (comment)

[andreivladbrg]

wasn't able to use Forge Std as a Node.js package, so I think this is not a question of preference but of necessity. We will keep installing Forge Std from git submodules.

I don't think you have updated the remappings and the import path correctly: https://github.com/sablier-labs/sablier-v2-integration-template/actions/runs/6668115091/job/18122989105

It shouldn't be a "necessity":

@forge-std/=node_modules/@forge-std/"

import { Test } from "@forge-std/src/Test.sol"

[PaulRBerg]

It shouldn't be a "necessity":

See foundry-rs/forge-std#208 (comment)

[PaulRBerg]

I don't think you have updated the remappings and the import path correctly:

I think I did:

https://github.com/sablier-labs/sablier-v2-integration-template/actions/runs/6668745614

[PaulRBerg]

Don't think you looked at the latest CI run, @andreivladbrg.

[andreivladbrg]

Still not a "necessity". This can be fixed by adding this remappings. You can run locally this branch: https://app.warp.dev/block/MtrSbAaMRDnU5ZrsyFFLul

A easier fix would be to import in forge-std from: import {DSTest} from "../lib/ds-test/src/test.sol";

Anyway, I am not in favor in installing forge-std as NPM, as said in my initial comment.

[PaulRBerg]

Still not a "necessity". This can be fixed by adding this remappings

Ah, yes. Remappings for DSTest! Good point.