Replies: 2 comments 1 reply
-
A note that might slightly influence these refactoring (not this one specifically): Any renaming of methods or events increases the complexity of the app and subgraphs due to backwards compatibility requirements. In the case of new flags, it's understandable why the change in signature is necessary, but for slight improvements in nomenclature, it might simply be worth setting the change aside (even though in this case, the suggested change makes the action more intuitive or contextual). These increases in complexity influence not only our own internal development time (duplicating event handling in subgraphs, conditionally calling a function based on contract version) but also our integrators' time supporting these updates. P.S. Not saying we shouldn't rename the concept in the OP, just added an argument worth taking into account when discussing similar matters. |
Beta Was this translation helpful? Give feedback.
-
Gonna close this discussion since it's a very low priority. |
Beta Was this translation helpful? Give feedback.
-
The task is to rename the
renounce
functionality (the function name, the event, etc.) todisableCancelability
.The rationale is two-fold:
transferable
flag in V2.1, there are now multiple properties of the stream that could be "renounced" by the sender.Beta Was this translation helpful? Give feedback.
All reactions