Remove the deltaCount check

[PaulRBerg]

Description

Implements what has been discussed in #96. In short: remove the check here:

https://github.com/sablierhq/v2-core/blob/5f13c560f6a3c99a10899ffc95907a8bc7414d84/src/SablierV2Pro.sol#L238-L241

Because the checkSegmentCounts function will automatically check the count of the segments is less than MAX_SEGMENT_COUNT.

What to Beware

The createWithDuration.tree tree (and consequently the tests too) will have to be refactored to account for two new testing branches:

1. The case when the block gas limit is overflown in the for loop. This is the only scenario in the protocol where the block gas limit can be reached, but it's only when the user passes too many segment deltas that this can happen.
   2. The case when the count of segmentMilestones is greater than MAX_SEGMENT_COUNT.

[andreivladbrg]

2. The case when the count of segmentMilestones is greater than MAX_SEGMENT_COUNT.

There is no need to test this , because we only check if the amountCount is greater than MAX_SEGMENT_COUNT.

[PaulRBerg]

because we only check if the amountCount is greater than MAX_SEGMENT_COUNT.

Well that's what I meant. I know that the contract doesn't directly check segmentMilestones. But the fact that it is possible to pass a higher-than-expected amountCount via segmentMilestones is an edge case that should be tested.

[andreivladbrg]

This error SablierV2Pro__SegmentCountOutOfBounds will never revert for the reason that only segmentMilestones is greater than MAX_SEGMENT_COUNT but instead SablierV2Pro__SegmentCountsNotEqualwill.

This case is tested in the PR
https://github.com/sablierhq/v2-core/blob/e8f6106271528cdd2f5cfc9a62bdb8dfff9bc08e/test/unit/sablier-v2-pro/create-with-duration/createWithDuration.t.sol#L32-L62