Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit metadata in _afterTokenTransfer hook #686

Merged
merged 6 commits into from
Sep 14, 2023

Conversation

andreivladbrg
Copy link
Member

Closes #670

Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM but we also need to write a test that shows that the metadata event gets emitted on transferFrom.

@andreivladbrg
Copy link
Member Author

but we also need to write a test that shows that the metadata event gets emitted on transferFrom.

We should add for both before and after hooks tests, then.

@PaulRBerg
Copy link
Member

We should add for both before and after hooks tests

Yes.

@andreivladbrg
Copy link
Member Author

@PaulRBerg pushed 2 more commits. Lmk if there is anything left

Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for the CI to finish and then you can squash and merge, @andreivladbrg.

@andreivladbrg andreivladbrg merged commit cfd3150 into 2.1 Sep 14, 2023
9 checks passed
@andreivladbrg andreivladbrg deleted the feat/emit-metadata branch September 15, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants