Completely remove the flash loan logic #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: update tests accordingly docs: remove flash loan reference in README
andreivladbrg
changed the title
smol-ninja
reviewed
Jan 10, 2024
smol-ninja
approved these changes
Jan 10, 2024
PaulRBerg
requested changes
Jan 10, 2024
There was a problem hiding this comment.
LGTM, good job @andreivladbrg. Feedback left in comments.
Other notes:
- The branch should have been named
refactor:instead offeat:. Removing stuff is not a feature. - We might have to redeploy the Comptroller in the next release
test/integration/concrete/comptroller/set-protocol-fee/setProtocolFee.tree
Outdated
Show resolved
Hide resolved
test/integration/concrete/comptroller/set-protocol-fee/setProtocolFee.t.sol
Outdated
Show resolved
Hide resolved
ok, before i was following these recommendations for choosing the words: https://gist.github.com/qoomon/5dfcdf8eec66a051ecd85625518cfd13 
yes, we would have to do that |
PaulRBerg
approved these changes
Jan 10, 2024
andreivladbrg
added a commit
that referenced
this pull request
Jan 21, 2024
* feat: remove flash loan logic test: update tests accordingly docs: remove flash loan reference in README * test: re-add setProtocolFee tests
andreivladbrg
added a commit
that referenced
this pull request
Feb 12, 2024
* feat: remove flash loan logic test: update tests accordingly docs: remove flash loan reference in README * test: re-add setProtocolFee tests
andreivladbrg
added a commit
that referenced
this pull request
Feb 15, 2024
* feat: remove flash loan logic test: update tests accordingly docs: remove flash loan reference in README * test: re-add setProtocolFee tests
andreivladbrg
added a commit
that referenced
this pull request
Feb 17, 2024
* feat: remove flash loan logic test: update tests accordingly docs: remove flash loan reference in README * test: re-add setProtocolFee tests
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
* feat: remove flash loan logic test: update tests accordingly docs: remove flash loan reference in README * test: re-add setProtocolFee tests
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
* feat: remove flash loan logic test: update tests accordingly docs: remove flash loan reference in README * test: re-add setProtocolFee tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #733