Rename create functions #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
force-pushed
the
refactor/rename-create-functions
branch
from
720cc45
to
51d96da
Compare
smol-ninja
requested changes
Jan 22, 2024
|
@smol-ninja as said here i have also renamed milestone to timestamp and delta to duration lmk if i missed something |
3 tasks
4 tasks
smol-ninja
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Looks good to me now. But we should merge #785 first, right?
refactor: rename delta to duration
andreivladbrg
force-pushed
the
refactor/rename-create-functions
branch
from
131567d
to
c365aa5
Compare
yeah, rebased now, after the ci ends i will merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #797