From 9283ad3bfa05ca9a8e126b077a74b503d4a5b730 Mon Sep 17 00:00:00 2001 From: Iaroslav Mazur Date: Sun, 9 Jul 2023 14:08:12 +0300 Subject: [PATCH 1/2] Changes in src/ resulting from the audit --- src/SablierV2ProxyPlugin.sol | 2 +- src/SablierV2ProxyTarget.sol | 2 +- src/interfaces/ISablierV2ProxyTarget.sol | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/SablierV2ProxyPlugin.sol b/src/SablierV2ProxyPlugin.sol index a9be57c2..a3e21783 100644 --- a/src/SablierV2ProxyPlugin.sol +++ b/src/SablierV2ProxyPlugin.sol @@ -69,7 +69,7 @@ contract SablierV2ProxyPlugin is //////////////////////////////////////////////////////////////////////////*/ /// @inheritdoc ISablierV2LockupSender - /// @notice Forwards the refunded assets to the proxy owner when the recipient cancel a stream whose sender is the + /// @notice Forwards the refunded assets to the proxy owner when the recipient cancels a stream whose sender is the /// proxy contract. /// @dev Requirements: /// - Must be delegate called. diff --git a/src/SablierV2ProxyTarget.sol b/src/SablierV2ProxyTarget.sol index 12158fa1..b7d112e1 100644 --- a/src/SablierV2ProxyTarget.sol +++ b/src/SablierV2ProxyTarget.sol @@ -203,7 +203,7 @@ contract SablierV2ProxyTarget is } } - // Transfers the assets to the proxy and approve the Sablier contract to spend them. + // Transfers the assets to the proxy and approves the Sablier contract to spend them. _transferAndApprove(address(lockupLinear), asset, transferAmount, permit2Params); // Create a stream for each element in the parameter array. diff --git a/src/interfaces/ISablierV2ProxyTarget.sol b/src/interfaces/ISablierV2ProxyTarget.sol index 51d8b21d..dcfaedbd 100644 --- a/src/interfaces/ISablierV2ProxyTarget.sol +++ b/src/interfaces/ISablierV2ProxyTarget.sol @@ -12,7 +12,7 @@ import { Permit2Params } from "../types/Permit2.sol"; /// @title ISablierV2ProxyTarget /// @notice Proxy target with stateless scripts for interacting with Sablier V2, designed to be used by -/// stream senders. +/// stream senders, recipients and the recipients' approved operators. /// @dev Intended for use with an instance of PRBProxy through delegate calls. Any standard calls will be reverted. interface ISablierV2ProxyTarget { /*////////////////////////////////////////////////////////////////////////// From ed8f626ffef07a5fe3e66874c673177122aae860 Mon Sep 17 00:00:00 2001 From: Paul Razvan Berg Date: Mon, 10 Jul 2023 16:14:16 +0300 Subject: [PATCH 2/2] revert: undo natspec change --- src/interfaces/ISablierV2ProxyTarget.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/interfaces/ISablierV2ProxyTarget.sol b/src/interfaces/ISablierV2ProxyTarget.sol index dcfaedbd..51d8b21d 100644 --- a/src/interfaces/ISablierV2ProxyTarget.sol +++ b/src/interfaces/ISablierV2ProxyTarget.sol @@ -12,7 +12,7 @@ import { Permit2Params } from "../types/Permit2.sol"; /// @title ISablierV2ProxyTarget /// @notice Proxy target with stateless scripts for interacting with Sablier V2, designed to be used by -/// stream senders, recipients and the recipients' approved operators. +/// stream senders. /// @dev Intended for use with an instance of PRBProxy through delegate calls. Any standard calls will be reverted. interface ISablierV2ProxyTarget { /*//////////////////////////////////////////////////////////////////////////