Replies: 2 comments
-
This is a good idea, but we've unfortunately run out of time, and we won't be able to implement this if we want to stick to the July 10 deadline :( Happy to re-consider the idea for V2.x Also, this is actually a feature request for V2 Core, so I will move the discussion over there. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Closing in favor of sablier-labs/v2-core#595. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The proxy plugin used for the Sablier on-cancel callback is called
onStreamCanceled
.v2-periphery/src/SablierV2ProxyPlugin.sol
Lines 77 to 79 in 453a35e
Wouldn't renaming it in something more unique (e.g.
onSablierStreamCanceled
) help prevent unintended collisions in the future (e.g. other project using the PRBProxy doing "Potato Streaming")? That's not necessarily intended to improve security (as bad players could still engineer plugins with our original name) but unknowing developers may benefit from this.Beta Was this translation helpful? Give feedback.
All reactions