-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark dir in tests #334
Comments
Alright. Marked it as a higher priority |
Any suggestions on the benchmark table? I assumed that users might be more interested into understanding gas usage based on batch size rather than number of segments/tranches. The latter is already documented in the v2-core repo.
cc @sablier-labs/engineers. Do we also want benchmark tables for |
Yes, batch size should be more important than the number of segments/ tranches. Feedback:
|
|
Let's do [5,10,20,30,50]. |
I now remember why I avoided large number of segments with higher batch size. Because it exceeds, block gas limit. With 24 segments, its not feasible to have batch size of more than 30 in LD and LT.
|
How about with batch size of 50, I change segments/tranches to 12 i.e. one year's worth of stream? |
Sounds good! |
Same as sablier-labs/v2-core#908
The text was updated successfully, but these errors were encountered: