Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install subdirectory not disabled and publicly reachable #507

Closed
gllmhyt opened this issue Mar 18, 2016 · 7 comments
Closed

Install subdirectory not disabled and publicly reachable #507

gllmhyt opened this issue Mar 18, 2016 · 7 comments
Labels

Comments

@gllmhyt
Copy link

gllmhyt commented Mar 18, 2016

Upgraded from 0.3.5 to 0.4.1, upgrade went well, but the /admin/install path seems not to be disabled.

For security reasons, this installation wizard is now disabled.

I can still access it. Configuration is NGinx and PHP-FPM.

@fabianwolf
Copy link
Contributor

The install tool autolock feature was removed in release 0.4.0
You'll have to protect access to install tool by using webserver config, if you need it disabled.
But we should modify that message after install, cause it doesn't tell the truth anymore ;)

@gllmhyt
Copy link
Author

gllmhyt commented Mar 20, 2016

Does it mean that anybody can access the install tool and mess with the SQLite file path?

@untitaker
Copy link
Member

That seems pretty problematic as the SQLite file path is arbitrary PHP code that is executed.

@untitaker
Copy link
Member

Deleting html/admin/install/index.php seems to do the trick. Perhaps this could be done as part of the upgrading process?

@evert evert added the bug label Mar 21, 2016
@evert
Copy link
Member

evert commented Mar 21, 2016

This is indeed bad news. I was under the impression that the installation will not run, if baikal is already fully configured/installed.

@evert evert closed this as completed in c199ac7 Mar 21, 2016
@evert
Copy link
Member

evert commented Mar 21, 2016

I'm now disabling the installer altogether if baikal was configured. Sorry I missed this :/

@gllmhyt
Copy link
Author

gllmhyt commented Mar 22, 2016

Upgrading now: thank you for the quick fix!

Edit: Upgrade done, it's working well. Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants