Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling for events #9

Open
u007 opened this issue Jan 8, 2019 · 1 comment
Open

error handling for events #9

u007 opened this issue Jan 8, 2019 · 1 comment

Comments

@u007
Copy link

u007 commented Jan 8, 2019

hi,
it would be best practice to have error handling in callbacks that handle exception and return the error back to the connector, especially when its not run via go routine.

onConnect, onDisconnect, onConnectError, onAuthentication, onSetAuthentication

thank you

@u007
Copy link
Author

u007 commented Jan 8, 2019

hi,

i saw that liveClient.Client.Connect() will not return anything, is it because there is a auto reconnect on failure? but i think it should return error if the client is unable to connect for the first time.
at least it should give up first if first attempt fail, alike how nginx proxy works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant