-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ball indicator not updating #26
Comments
@karanjhinga did you find a solution for this? Or did you edit this. |
Change return to true and the ball indicator will update. But you should check carefully about the performance of your app. |
I changed shouldComponentUpdate(nextProps: props, nextState: state) {
let shouldUpdate = nextProps.value !== this.props.value || nextProps.value !== this.state.value;
if (shouldUpdate) {
this._changeState(nextProps.value);
}
return shouldUpdate;
} |
Is the above solution of Jun 7, 2022 by BaderSerhan the preferred solution? If so, please could the repository be updated accordingly? |
We are currently facing the same issue. any ideas? |
There is the following fork of this repo that has the ball number updating: |
The problem lies with the component should update
By making this u are preventing the component from rerendering
The text was updated successfully, but these errors were encountered: