Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add2 and add4 chords not correctly generated #123

Open
romeoleung opened this issue Sep 11, 2018 · 0 comments
Open

add2 and add4 chords not correctly generated #123

romeoleung opened this issue Sep 11, 2018 · 0 comments

Comments

@romeoleung
Copy link

When creating chords with added tone, if the tone number is 2 or 4, it only generates a triad without the added notes.
Example:
var c4 = teoria.note("C4");
teoria.Chord(c4, "add2").simple(); // => Only getting ["c", "e", "g"] . expected is to get ["c", "d", "e", "g"]
teoria.Chord(c4, "add4").simple(); // => Only getting ["c", "e", "g"] . expected is to get ["c", "e", "f", "g"]

Adding this code after line 1188 temporarily resolves the issue, but the note's is always added to the last:

else if (next === '2')
    additionals.push('M2');
else if (next === '4')
   additionals.push('P4');

Hopefully this could be fixed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant