Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase MAX_GSTRINGS to support more stats #29

Closed
danielnelson opened this issue Jan 17, 2020 · 2 comments
Closed

Increase MAX_GSTRINGS to support more stats #29

danielnelson opened this issue Jan 17, 2020 · 2 comments

Comments

@danielnelson
Copy link

In Telegraf we are running into the MAX_GSTRINGS limit when reading stats. Currently the MAX_GSTRINGS is set to 100, and I see it was bumped up in #2 several years back from 100.

The NIC we are having issues has about 2480 stats according to ethtool -S. Do you think it would it make sense to further increase this limit?

influxdata/telegraf#6913

@safchain
Copy link
Owner

@danielnelson yes feel free to send a PR to increase it if needed

@ykuksenko
Copy link
Contributor

This was bumped to 4096 in #28
Someone asked to bump this to 8192 shortly after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants