Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #244, fix docker build #245

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fix #244, fix docker build #245

merged 2 commits into from
Aug 28, 2023

Conversation

ptqa
Copy link
Contributor

@ptqa ptqa commented Aug 23, 2023

Also fixed Dockerfile otherwise it was complaining When using COPY with more than one source file, the destination must be a directory and end with a /

@ptqa ptqa requested a review from Uxio0 as a code owner August 23, 2023 11:02
@github-actions
Copy link

github-actions bot commented Aug 23, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ptqa
Copy link
Contributor Author

ptqa commented Aug 23, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 23, 2023
@github-actions
@ptqa has signed the CLA in #245
ab65cf1
Uxio0
Uxio0 reviewed Aug 28, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Uxio0
Uxio0 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot reproduce this, it's working on docker v24.0.5, either way your PR looks good and I will merge it

@Uxio0 Uxio0 merged commit 69f9f1c into safe-global:master Aug 28, 2023
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
@Uxio0
Copy link
Member

Uxio0 commented Aug 28, 2023

Thank you for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptqa @Uxio0