Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest safe-deployments #218

Closed
svanegmond opened this issue Jul 13, 2022 · 1 comment
Closed

Update to latest safe-deployments #218

svanegmond opened this issue Jul 13, 2022 · 1 comment

Comments

@svanegmond
Copy link

svanegmond commented Jul 13, 2022

Description

safe-core-sdk-types is not aware of recent new blockchains because it depends on an old version of safe-deployments.

Environment

safe-react mentions these SDK dependencies in package.json:

"@gnosis.pm/safe-apps-sdk": "7.3.0",
"@gnosis.pm/safe-apps-sdk-v1": "npm:@gnosis.pm/safe-apps-sdk@0.4.2",
"@gnosis.pm/safe-core-sdk": "^1.3.0",
"@gnosis.pm/safe-core-sdk": "^2.0.0",
"@gnosis.pm/safe-react-gateway-sdk": "^3.1.1",
"@gnosis.pm/safe-core-sdk-types": "1.0.0",

Itself safe-rect requires safe-deployments ^1.15.0

However the core SDK build has its own copy of the safe-deployments module, it seems:

node_modules/@gnosis.pm/safe-deployments/src/assets/v1.3.0/gnosis_safe_l2.json
node_modules/@gnosis.pm/safe-deployments/dist/assets/v1.3.0/gnosis_safe_l2.json
node_modules/@gnosis.pm/safe-core-sdk/node_modules/@gnosis.pm/safe-deployments/src/assets/v1.3.0/gnosis_safe_l2.json
node_modules/@gnosis.pm/safe-core-sdk/node_modules/@gnosis.pm/safe-deployments/dist/assets/v1.3.0/gnosis_safe_l2.json
node_modules/@gnosis.pm/safe-core-sdk-types/node_modules/@gnosis.pm/safe-deployments/src/assets/v1.3.0/gnosis_safe_l2.json
node_modules/@gnosis.pm/safe-core-sdk-types/node_modules/@gnosis.pm/safe-deployments/dist/assets/v1.3.0/gnosis_safe_l2.json

The ones under safe-core-sdk do not have my chain ID in them, and as a result, the safe-tx-service doesn't know how to talk to my chain for those parts that are routed through the SDK, such as ownership changes.

Steps to reproduce

Build current safe-core-sdk

Compare versions of safe-deployments used within.

Expected result

Always use current release of safe-deployments

@svanegmond
Copy link
Author

Perhaps rephrasing the dependency as 1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants