Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safe-core-sdk README outdated #55

Closed
antomor opened this issue Aug 12, 2021 · 1 comment · Fixed by #56
Closed

safe-core-sdk README outdated #55

antomor opened this issue Aug 12, 2021 · 1 comment · Fixed by #56

Comments

@antomor
Copy link
Contributor

antomor commented Aug 12, 2021

The README of the safe-core-sdk package is outdated, and it doesn't include the changes related to the introduction of the TransactionResult interface.
All the examples with execute or approveTransactionHash call the wait method on the TransactionResult interface, but it doesn't include such method.

Example

Wrong version:

const approveTxResponse = await safeSdk2.approveTransactionHash(txHash)
await approveTxResponse.wait()

Fixed version:

const executeTxResponse = await safeSdk3.executeTransaction(safeTransaction)
await executeTxResponse.transactionResponse?.wait()
@antomor antomor changed the title Readme is outdated safe-core-sdk README outdated Aug 12, 2021
@antomor antomor changed the title safe-core-sdk README outdated safe-core-sdk README outdated Aug 12, 2021
@germartinez
Copy link
Member

Good catch @antomor. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants